Revert "http: make HEAD method to work with keep-alive"#38949
Revert "http: make HEAD method to work with keep-alive"#38949targos wants to merge 1 commit intonodejs:masterfrom
Conversation
This reverts commit 7afa533. The change breaks clients like cURL. Fixes: nodejs#38922
github-actions
bot
added
http
|
Hi, @bl-ue and @VoltrexMaster! I appreciate all your comments in the issue tracker, but it would be helpful if you could refrain from "approving" pull requests. Overall, it causes a lot of notification noise. A thumbs-up reaction would convey the same information without piling up notifications for collaborators. Given how much you both watch and interact with the repository, I want to make sure you are aware of our triager role, in case that is of interest to you. |
|
Hi @targos! Sure, I'll avoid doing that - I didn't realize it was bothering you :) |
As far as I know, there are no meetings for triagers, so I think that's not a problem. Name is also probably not a problem. We allow people to put whatever name they want (although we'd probably step in and block anything that was intentionally misleading, like using the name of an existing collaborator, or something intentionally and blatantly offensive). Email, I'm less sure about. We need a way to get in touch with people outside of GitHub sometimes, and that is usually through the email listed in the README. |
Understood, so maybe I'll just have to decline — but I'm available all day every day at https://gitter.im/bl-ue ;) |
|
@nodejs/tsc @nodejs/lts Does anyone object to pulling this into v14.17.1, to avoid having the change in LTS for too long? |
|
No objections to including in 14.17.1 from me. |
|
no objection, actually it's the course of action that I would recommend. |
mmarchini
left a comment
mmarchini
left a comment
There was a problem hiding this comment.
and +1 on pulling it on 14.17.1
This reverts commit 7afa533. The change breaks clients like cURL. Fixes: #38922 PR-URL: #38949 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
|
Landed in f504c9c |
This reverts commit 7afa533. The change breaks clients like cURL. Fixes: #38922 PR-URL: #38949 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This reverts commit 7afa533. The change breaks clients like cURL. Fixes: #38922 PR-URL: #38949 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
14 participants
This reverts commit 7afa533.
The change breaks clients like cURL.
Fixes: #38922